search

ocadotechnology / django-nuit

A front-end framework based upon Zurb Foundation for Django applications
Apache License 2.0
6 stars 5 forks source link

Add support for Django 1.8/1.9 #7

Closed Ocado-NickBrown closed 8 years ago

Ocado-NickBrown commented 8 years ago

Currently doesn't support 1.8:

$ python example_project/manage.py runserver --insecure
No handlers could be found for logger "django_autoconfig.environment_settings.autoconfig"
Traceback (most recent call last):
  File "example_project/manage.py", line 12, in <module>
    execute_from_command_line(sys.argv)
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 350, in execute_from_command_line
    utility.execute()
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django/core/management/__init__.py", line 302, in execute
    settings.INSTALLED_APPS
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django/conf/__init__.py", line 55, in __getattr__
    self._setup(name)
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django/conf/__init__.py", line 43, in _setup
    self._wrapped = Settings(settings_module)
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django/conf/__init__.py", line 99, in __init__
    mod = importlib.import_module(self.SETTINGS_MODULE)
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/nicholas.brown/projects/git/axis/example_project/example_project/settings.py", line 171, in <module>
    autoconfig.configure_settings(globals())
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/django_autoconfig/autoconfig.py", line 167, in configure_settings
    module = importlib.import_module("%s.autoconfig" % (app_name,))
  File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/nicholas.brown/.virtualenvs/axis/local/lib/python2.7/site-packages/nuit/autoconfig.py", line 28, in <module>
    from django.template.base import add_to_builtins
ImportError: cannot import name add_to_builtins
benbacardi commented 8 years ago

Current thoughts:

Add must_be_first = False to ExtendNode, require people to {% load nuit %} first. Still try and add_to_builtins where we can, so that for <1.9 no changes are required.