ocadotechnology / hexagonjs

A modular, themable collection of components for modern browsers
https://www.hexagonjs.io
Apache License 2.0
51 stars 15 forks source link

fix(form-builder): move form builder buttons back to bottom of form #545

Closed charlieTheBotDev closed 5 years ago

charlieTheBotDev commented 5 years ago

Description

An unnecesary prepend used during testing managed to make its way into the last release (making forms work correctly in modals) which meant the form buttons added (submit/additional buttons) were inserted at the start of the form instead of continuing to be placed at the bottom of the form.

As the change was only solving some minor spacing problems, reverting it makes the most sense. I'll follow up with investigation into the modal issue moving forwards.

I also noticed an issue with the modal demo not working as intended due to some refactoring (onClose -> close) so fixed that as well

Motivation and Context

Bugfix

How Has This Been Tested?

Visual testing only in the demo

Screenshots (if appropriate):

Before

Screenshot 2019-09-04 at 08 00 37

Screenshot 2019-09-04 at 08 00 32

After

Screenshot 2019-09-04 at 08 01 54

Screenshot 2019-09-04 at 08 01 58

Checklist:

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.02%) to 69.412% when pulling b7d5aa5ffe387bcde5547c4fc2c94c9e9809e087 on patch into f0f88e6f9583b5830e008de257c4bb2c52efa118 on master.