Fixed validator example - Githubissues

ocadotechnology / hexagonjs

A modular, themable collection of components for modern browsers

https://www.hexagonjs.io

Apache License 2.0

51 stars 15 forks source link

Fixed validator example #569

Closed Kerenhb closed 4 years ago

Kerenhb commented 4 years ago

Description

String needs to be returned for this example to actually work otherwise it will always assume it's valid.

Motivation and Context

Confusing as example doesn't work as shown

How Has This Been Tested?

Locally when using this in my project

Screenshots (if appropriate):

Checklist:

[ ] I have added a tag to this pull request that indicates the impact of the change (patch, minor or major)
[ ] My code follows the code style of this project.
[ ] I have updated the documentation accordingly. (This includes updating the changelog).
[x] I have read the CONTRIBUTING document. (Last updated 24 March 2020)
[ ] All my changes are covered by tests.
[x] This request is ready to review and merge

coveralls commented 4 years ago

Coverage increased (+0.05%) to 69.909% when pulling 15dceac00551ccf10587bf3b739411ade9f87f73 on Kerenhb:patch-1 into 4243a7b7b9ce0d6c4c6f023f9b120e9a52fde25f on ocadotechnology:master.