ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
56 stars 62 forks source link

fix: 1476-Video sound keeps playing after closing the popup it's in #1554

Closed AbdelrahmanDeghedy closed 6 months ago

AbdelrahmanDeghedy commented 6 months ago

Description


This change is Reviewable

AbdelrahmanDeghedy commented 6 months ago

Reviewed 1 of 1 files at r1, all commit messages. Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AbdelrahmanDeghedy)

game/static/game/js/drawing.js line 1020 at r1 (raw file):

  // https://gist.github.com/cferdinandi/9044694
  const video = document.getElementsByClassName("video");
  var iframeSrc = video[0].src;

Can you replace var with let please πŸ™ 😊

I have replaced it with a const since it's not mutated.