ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
57 stars 78 forks source link

Scoring issue with Rapid Router #1570

Closed lauracumming closed 6 months ago

lauracumming commented 8 months ago

Describe the bug It seems we are overscoring in some of our Rapid Router levels. There are certain levels that will not have a route score or algorithm score and therefore be out of a total of 10. However, we seem to be awarding 20 points as a full score regardless of this which results in the image below.

To Reproduce Steps to reproduce the behaviour:

  1. Login as a student (school or independent).
  2. Go to 'level 92'.
  3. Complete the level with full points.
  4. Go back to the list of levels.
  5. Notice that the score shows 20/10.

Expected behaviour The score should be 10/10.

Screenshots image (2)

Additional context This is probably due to an inconsistency in the Python logic when it comes to scoring the level. Please familiarise yourself with how a level is given a max_score by looking at the Level model and the associated migrations for creating / editing these levels.