search

ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
57 stars 78 forks source link

Save user's preferred language across Rapid Router levels #1615

Closed evemartin closed 2 months ago

evemartin commented 4 months ago

At the moment, whenever you leave a level and select a new one, the language dropdown resets (to your browser's default language) even if you have changed it in the level. It would be good if Rapid Router saved the user's preferred language across levels instead of resetting it every time.

One possible direction to look in for this ticket is cookies, similar to what we did with the Rapid Router mute cookie a little while ago.

lauracumming commented 3 months ago

Hey team! Please add your planning poker estimate with Zenhub @evemartin @faucomte97 @SKairinos

evemartin commented 2 months ago

Update before I go on holiday: tested on dev and ready for review!

faucomte97 commented 2 months ago

Reviewing - checking something with the legal team re cookie consent behaviour.

faucomte97 commented 2 months ago

Ready for review on staging. Please test that the cookies not only work when consent to functional cookies, but also that the cookies get deleted when withdrawing consent after the cookies have been activated. You can check that in the Application tab of the browser DevTools when looking at the cookie list. The muted and preferredLanguage cookies should both disappear (only when going back to a Rapid Router level, not before).

SKairinos commented 2 months ago

LGTM - I followed the above comment

lauracumming commented 2 months ago

LGTM - Also noted the above

lauracumming commented 2 months ago

LGTM

SalmanAsh commented 2 months ago

LGTM