ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
56 stars 61 forks source link

Cow placement #1617

Closed lauracumming closed 2 weeks ago

lauracumming commented 1 month ago

Describe the bug It is possible to place a cow at the start and end of a map. This shouldn't be possible. No objects should be allowed on these squares.

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Level Creator and create a map'
  2. Click a cow
  3. Drag to start square
  4. See cow is happy on square

Expected behaviour Cow should not be happy on square, cow needs to be forbidden from square

Screenshots

Screenshot 2024-05-16 at 12.44.55.png

Additional context Please stop this cow behaviour

lauracumming commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @faucomte97 @SKairinos @evemartin

faucomte97 commented 1 month ago

Reviewed and left comments. Mentioned a user feedback concern that @lauracumming might have some input on.

Depending on what is decided, feel free to ping me even if I'm offline and I can rereview.

evemartin commented 1 month ago

@faucomte97 I've responded to your comments! Laura suggested we leave the user feedback as it is (with the highlighted red/green squares) for right now but discuss adding more in the future - I have created this task to cover it!

lauracumming commented 3 weeks ago

LGTM

SKairinos commented 3 weeks ago

I ran into this issue

image.png
evemartin commented 3 weeks ago

When exactly did this screen appear?

lauracumming commented 3 weeks ago

Are you still logged into the admin?

SKairinos commented 3 weeks ago

maybe. why would that have an impact on RR, though? is it a known bug?

SKairinos commented 3 weeks ago

Maybe, will check. Why would that impact RR, though? Is it a known bug?

faucomte97 commented 3 weeks ago

LGTM. Stefan's issue is unrelated: https://app.zenhub.com/workspaces/code-for-life-development-56f2afba6e54555c586f6db3/issues/gh/ocadotechnology/codeforlife-portal/2315

faucomte97 commented 3 weeks ago

LGTM

SKairinos commented 2 weeks ago

LGTM