search

ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
56 stars 61 forks source link

Bug - custom level score should be 10/10 #1619

Closed lauracumming closed 2 weeks ago

lauracumming commented 1 month ago

Describe the bug It says 10/20, rather than 10/10 when the scoring comes up on level editor

To Reproduce Steps to reproduce the behaviour:

  1. Go to 'Level editor'
  2. Click on 'play a level that you created previously or make a new one'
  3. complete the level
  4. See error

Expected behaviour Should be 10/10 innit

Screenshots

Screenshot 2024-05-08 at 11.52.49.png

Additional context @faucomte97 knows what needs changing

Staging Approved

Prod Approved

faucomte97 commented 1 month ago

Messaged @evemartin about the issue that was found on dev.

Other than said issue which I believe is a bug unrelated to this task, everything on dev looked good to me. I have approved so can be merged.

evemartin commented 1 month ago

The issue Florian mentioned in his comment is that when a teacher is not part of a school they cannot save a created level in the Level Editor. This might be due to an inaccurate if check in save_level_for_editor - for more information, see the new bug task created here

lauracumming commented 3 weeks ago

LGTM

SKairinos commented 3 weeks ago

I ran into this issue

image.png
faucomte97 commented 3 weeks ago

LGTM

faucomte97 commented 3 weeks ago

Stefan's issue is unrelated: https://app.zenhub.com/workspaces/code-for-life-development-56f2afba6e54555c586f6db3/issues/gh/ocadotechnology/codeforlife-portal/2315

faucomte97 commented 3 weeks ago

LGTM

SKairinos commented 2 weeks ago

LGTM