ocadotechnology / rapid-router

A Blockly and python based educational game aimed at students age 5-14.
https://www.codeforlife.education
Other
57 stars 81 forks source link

bug: cow reorients when dragged a second time #1718

Closed evemartin closed 2 weeks ago

evemartin commented 2 months ago

Describe the bug Right after a cow is dragged onto the Level Editor grid, when it is re-dragged to a new spot on the grid, its orientation changes. This reorientation does not happen if it has already been re-dragged to a new spot.

To Reproduce Steps to reproduce the behaviour:

  1. Go to the Level Editor
  2. Drag a cow to place it on the grid. Do not place it on a road
  3. Re-drag the cow to a new spot on the grid. Notice that its orientation changes so that it faces a different direction

Expected behaviour The cow's orientation while dragging should not change. (The orientation should only change when the cow is dragged to a road and the cow reorients to match the road, this functionality is working though so is not part of this task)

Screenshots

https://github.com/user-attachments/assets/0b2ba4bf-3733-4e47-bc52-df4e5e206bfe

Additional context This task might be related to Task #1717 but because it is a behaviour specific to cows rather than all scenery I have made it separate just in case

evemartin commented 2 weeks ago

Video: Screencast from 04-09-24 11:09:45.webm

faucomte97 commented 2 weeks ago

I don't believe this is relevant anymore, following the work on #1746. The remainder of the work is to make the cow rotatable, as covered in task #1717.