search

ocaml-attic / mirari

Mirage Application Builder
6 stars 5 forks source link

odd syntax for main- etc #20

Open mor1 opened 10 years ago

mor1 commented 10 years ago

the syntax main-noip etc seems very odd to me; the following seems more natural (and more orthogonal across :

(i guess you could default ip-netmask and ip-gateway to a /24 and x.x.x.1 if you wanted.)

make sense? comments?

avsm commented 10 years ago

I agree with your syntax.

On 11 Aug 2013, at 23:23, Richard Mortier notifications@github.com wrote:

the syntax main-noip etc seems very odd to me; the following seems more natural (and more orthogonal across :

main: xxx should define the entry point alone (ie., be orthogonal to network config) networking should be specified by the presence of either ip-use-dhcp: true or the presence of all three of ip-static-{address,netmask,gateway}: x.x.x.x (i guess you could default ip-netmask and ip-gateway to a /24 and x.x.x.1 if you wanted.)

make sense? comments?

— Reply to this email directly or view it on GitHub.

samoht commented 10 years ago

I guess I was in a rush when I've added that main-noip target (and didn't have enough examples to find the good design abstraction).

So yes, agreed as well with that design change.

vbmithr commented 10 years ago

On 12/08/2013 09:29, Thomas Gazagnaire wrote:

I guess I was in a rush when I've added that |main-noip| target (and didn't have enough examples to find the good design abstraction).

So yes, agreed as well with that design change.

I added the main-nopip target, as a quick hack. I'm going to implement the suggested change as everybody seem to agree :)