search

ocaml-attic / ocaml-cstruct

Map OCaml arrays onto C-like structs via a syntax extension, and generate functions to convert to-and-from native OCaml values.
http://www.openmirage.org/
10 stars 2 forks source link

Remove IP functions #13

Closed dsheets closed 10 years ago

dsheets commented 10 years ago

The IPv4 and IPv6 functions don't really belong in this library.

avsm commented 10 years ago

Need to check that there are no upstream consumers first.

djs55 commented 10 years ago

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372 .

Dave Scott

avsm commented 10 years ago

Yeah, ocamlot can do that, but not Travis (easily). How did it break the block driver???

On 21 Oct 2013, at 13:26, Dave Scott notifications@github.com wrote:

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372 .

Dave Scott — Reply to this email directly or view it on GitHub.

dsheets commented 10 years ago

Rolling out the consumer dependencies is high on my ocamlot to-do list. I believe that when I started ipaddr, I did a survey and found that only mirage-net and tuntap used the IP address functions of cstruct.

djs55 commented 10 years ago

I think I was being naughty and peeking inside the Cstruct.t and something became an int32. Not investigated yet but I bet that was it!

On Mon, Oct 21, 2013 at 1:31 PM, Anil Madhavapeddy <notifications@github.com

wrote:

Yeah, ocamlot can do that, but not Travis (easily). How did it break the block driver???

On 21 Oct 2013, at 13:26, Dave Scott notifications@github.com wrote:

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHub< https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372> .

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26712762 .

Dave Scott

avsm commented 10 years ago

It really should be API compatible -- could you report this one? -a

On 21 Oct 2013, at 13:52, Dave Scott notifications@github.com wrote:

I think I was being naughty and peeking inside the Cstruct.t and something became an int32. Not investigated yet but I bet that was it!

On Mon, Oct 21, 2013 at 1:31 PM, Anil Madhavapeddy <notifications@github.com

wrote:

Yeah, ocamlot can do that, but not Travis (easily). How did it break the block driver???

On 21 Oct 2013, at 13:26, Dave Scott notifications@github.com wrote:

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHub< https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372> .

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26712762 .

Dave Scott — Reply to this email directly or view it on GitHub.

djs55 commented 10 years ago

Sure. Just in the middle of a vchan-inspired rebuild, will recreate the scenario...

On Mon, Oct 21, 2013 at 1:58 PM, Anil Madhavapeddy <notifications@github.com

wrote:

It really should be API compatible -- could you report this one? -a

On 21 Oct 2013, at 13:52, Dave Scott notifications@github.com wrote:

I think I was being naughty and peeking inside the Cstruct.t and something became an int32. Not investigated yet but I bet that was it!

On Mon, Oct 21, 2013 at 1:31 PM, Anil Madhavapeddy < notifications@github.com

wrote:

Yeah, ocamlot can do that, but not Travis (easily). How did it break the block driver???

On 21 Oct 2013, at 13:26, Dave Scott notifications@github.com wrote:

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHub<

https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372>

.

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26712762> .

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26714426 .

Dave Scott

djs55 commented 10 years ago

@avsm: See mirage/ocaml-cstruct/issues/14

The issue seems to be a duplicate unused field name: used to be harmless, now triggers an error.

On Mon, Oct 21, 2013 at 2:05 PM, David Scott scott.dj@gmail.com wrote:

Sure. Just in the middle of a vchan-inspired rebuild, will recreate the scenario...

On Mon, Oct 21, 2013 at 1:58 PM, Anil Madhavapeddy < notifications@github.com> wrote:

It really should be API compatible -- could you report this one? -a

On 21 Oct 2013, at 13:52, Dave Scott notifications@github.com wrote:

I think I was being naughty and peeking inside the Cstruct.t and something became an int32. Not investigated yet but I bet that was it!

On Mon, Oct 21, 2013 at 1:31 PM, Anil Madhavapeddy < notifications@github.com

wrote:

Yeah, ocamlot can do that, but not Travis (easily). How did it break the block driver???

On 21 Oct 2013, at 13:26, Dave Scott notifications@github.com wrote:

As an aside, it would be handy to have a tool which could recompile everyone that depends on you, to get early warning of future flames. For example cstruct.0.8.0 broke my xen-block-driver, sniff

On Mon, Oct 21, 2013 at 12:26 PM, Anil Madhavapeddy < notifications@github.com> wrote:

Need to check that there are no upstream consumers first.

— Reply to this email directly or view it on GitHub<

https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26709372>

.

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26712762> .

Dave Scott — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mirage/ocaml-cstruct/issues/13#issuecomment-26714426 .

Dave Scott

Dave Scott

avsm commented 10 years ago

Removed in 1.0