search

ocaml-batteries-team / batteries-included

Batteries Included project
http://ocaml-batteries-team.github.com/batteries-included/hdoc2/
Other
517 stars 106 forks source link

Failed to install with the trunk #331

Closed bobzhang closed 11 years ago

bobzhang commented 11 years ago

Error: Signature mismatch: ... The field cygwin' is required but not provided The fieldwin32' is required but not provided The field `unix' is required but not provided Command exited with code 2. make: *\ [_build/qtest/all_tests.byte] Error 10

thelema commented 11 years ago

What version of OCaml?

thelema commented 11 years ago

oh, you mean trunk OCaml. Yes, they've put more identifiers into Sys, and batteries' compatibility tests find that we're not exporting those identifiers.

bobzhang commented 11 years ago

Yes, I think the compatibility test should be version dependent, we may be cautious to add this check

thelema commented 11 years ago

I don't recall the compatibility test being required for install; if it is, I can fix this.

bobzhang commented 11 years ago

It seems that batteries still depends on oUnit, is there any chance to remove such dependency?

bobzhang commented 11 years ago

IMHO, compatibility test may need conditional compilation

thelema commented 11 years ago

The tests depend on oUnit, the main compile shouldn't need oUnit.

thelema commented 11 years ago

Are you compiling with oasis? try just running make.

bobzhang commented 11 years ago

I tried make all or make, neither works all: $(QTEST_RUNTIME) @echo "Build mode:" $(MODE) $(OCAMLBUILD) $(OCAMLBUILDFLAGS) $(TARGETS)

thelema commented 11 years ago

I don't see this in master[1], nor in the v1 branch[2]. What branch are you running?

[1] https://github.com/ocaml-batteries-team/batteries-included/blob/master/Makefile#L69 [2] https://github.com/ocaml-batteries-team/batteries-included/blob/v1/Makefile#L63

bobzhang commented 11 years ago

It seems that I did not get the right version, now it works smoothly, thanks for your help !