Refactor nightly scripts to re-use code

ocaml-bench / sandmark

A benchmark suite for the OCaml compiler

The Unlicense

82 stars 40 forks source link

Refactor nightly scripts to re-use code #376

Closed punchagan closed 1 week ago

punchagan commented 2 years ago

This PR removes extracts duplicated code from nightly_navajo and nightly_turing scripts into a common script.
Minor refactor of the run_all_custom.sh code.

punchagan commented 2 years ago

I removed the code that tries to copy benchmarks from testing to main branch and the slack notification code. I'll send that as a separate PR possibly as a GitHub action as discussed with @shakthimaan. The refactor seems useful, but we possibly need it at this point since 1) the service has been announced publicly and 2) there's only two machines where the nightly runs.

punchagan commented 1 week ago

We copy the nightly_{hostname}.sh scripts separately to the servers to run the benchmarks. This may not be the best way to configure the server, but with the current setup refactoring common code makes the setup more clunky.