ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

Remove gnuplot dependency for benchmarks #427

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

gnuplot was added as a dependecy as a part of the PR #343 since a library for running the Irmin benchmarks depended on it. But, we don't currently run the irmin benchmarks and the gnuplot dependency installs a whole bunch of X11 dependencies when setting up the OS for running the benchmarks. This makes the setup longer than it needs to be, as of now.

shakthimaan commented 1 year ago

we don't currently run the irmin benchmarks

My suggestion is to leave a TODO comment with the actual dependency name instead of removing it completely. When the ppxlib dependency is resolved, we will run the Irmin benchmarks again.

shakthimaan commented 1 year ago

Thanks! LGTM.