ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

Moving from inline shell in the Makefile to separate shell scripts #436

Open ElectreAAS opened 1 year ago

ElectreAAS commented 1 year ago

Cleaning the Makefile, one script at a time

This PR will eventually resolve #330, at least Phase 1. The Makefile is huge and ripe with quoted shell, which leads to quoting issues, especially with empty variables. Putting everything in bash scripts means we don't need to juggle makefile syntax and bash syntax, so less error-prone. I also use Shellcheck to lint the scripts.

Design decisions

ElectreAAS commented 1 year ago

I am considering splitting this PR into several smaller independent PRs, as the multiple shell scripts are independent.

ElectreAAS commented 1 year ago

I rebased this branch on main, hence the multiple force pushes

ElectreAAS commented 1 year ago

Progress report: All of the complicated make commands have been replaced by shell scripts Some 2-3 lines one still remain