Open ElectreAAS opened 1 year ago
I am considering splitting this PR into several smaller independent PRs, as the multiple shell scripts are independent.
I rebased this branch on main, hence the multiple force pushes
Progress report: All of the complicated make commands have been replaced by shell scripts Some 2-3 lines one still remain
Cleaning the Makefile, one script at a time
This PR will eventually resolve #330, at least Phase 1. The Makefile is huge and ripe with quoted shell, which leads to quoting issues, especially with empty variables. Putting everything in bash scripts means we don't need to juggle makefile syntax and bash syntax, so less error-prone. I also use Shellcheck to lint the scripts.
Design decisions
@
at the start of a lot of commands, and>/dev/null
at the end of others. We should stillecho
what we are doing so errors have context in the logs.make build_and_run
ormake; make run
... Configuration should be in one easily identified place.make bench
should just not need to build anything.