search

ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

Fix wget usage in Makefile #437

Closed ElectreAAS closed 1 year ago

ElectreAAS commented 1 year ago

In my search to clean the Makefile, I discovered a bug: We use wget to check for valid urls, but don't exit in case of failure. Adding the exits showcases that in some scenarios, wget might not be installed at all, which leads to printing "Error [URL] doesn't exist" even though it does exist, but the system didn't find wget. The first commit of this PR fixes the printing and the exits, the second fixes the root bug and actually installs wget.

ElectreAAS commented 1 year ago

Static link to the failing log on current-bench here : http://autumn.ocamllabs.io:8081/job/2023-01-12/155852-ocluster-build-e5e20f We can see that wget wasn't installed

ElectreAAS commented 1 year ago

The latest commit fixes the root bug: wget wasn't installed in the dockerfile that runs on current-bench

punchagan commented 1 year ago

Thanks for fixing this, @ElectreAAS !