search

ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

Run the run_all_custom.sh script wrapped in flock #438

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

The nightly cron jobs on Navajo have started to take almost a day, and sometimes this could lead to multiple benchmarks getting started at the same time. To prevent this we use the flock utility to detect if the process that previously owned a lock file is still alive, and not start another process if that's the case.

The call to flock is added to the nightly_* scripts so that it's more visible to the developers, rather than being hidden away in the crontab file.

punchagan commented 1 year ago

@shakthimaan can we merge this? Please let me know if you need me to clarify something to help you review and merge this.

shakthimaan commented 1 year ago

Can you also please add flock to the DEPENDENCIES list in the Makefile?

https://github.com/ocaml-bench/sandmark/blob/main/Makefile#L79

punchagan commented 1 year ago

Can you also please add flock to the DEPENDENCIES list in the Makefile?

We can add it here, but we are invoking the flock command before we run any make targets. So, not sure it's helpful when flock is not installed on a system.

shakthimaan commented 1 year ago

Okay. It is only for the nightly service, so that is fine. LGTM! Merged and deployed in production on both navajo and turing servers.