search

ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

A number of parallel benchmarks seem to be broken #446

Open kayceesrk opened 1 year ago

kayceesrk commented 1 year ago

image

Corresponding sandmark nightly run

punchagan commented 1 year ago

The benchmarks that are broken here are the MPL benchmarks added in #404 & #439. The benchmarks are broken due to missing serial versions of the benchmarks as noted in the comment here: https://github.com/ocaml-bench/sandmark/pull/439#issuecomment-1400252463

shwestrick commented 1 year ago

It should be easy to generate a sequential version of the MPL benchmarks. Just need to replace the ForkJoin module with an equivalent sequential implementation. All parallelism goes through that module.

E.g. let par f g = (f(), g()) and similarly for the other functions.