search

ocaml-bench / sandmark

A benchmark suite for the OCaml compiler
The Unlicense
82 stars 40 forks source link

Ensure configure options with spaces in them don't break builds #459

Closed punchagan closed 1 year ago

punchagan commented 1 year ago

Previously, OCAMLCONFIGOPTION set to something like "CC='gcc -Wa,-mbranches-within-32B' AS='as -mbranches-within-32B'" would break the builds because of the spaces in the environment variables. The build failed with the following error:

configure: error: unrecognized option: `-Wa,-mbranches-within-32B''

For instance, see the build logs here.

This commit ensures that spaces inside the single quoted strings are escaped correctly and the configure step runs correctly.