ocaml-community / cppo

C-style preprocessor for OCaml
BSD 3-Clause "New" or "Revised" License
107 stars 26 forks source link

Allow empty patch version #76

Closed liyishuai closed 3 years ago

liyishuai commented 3 years ago

Doesn't fix compatibility with Coq 8.13.dev (which should be later than 8.13.2), but can at least deal with 8.13+beta1.

mjambon commented 3 years ago

It looks like a reasonable solution to me. My reasoning is:

I don't know whether or how we should deal with versions like 8.13.dev, though.

liyishuai commented 3 years ago

Lysxia/coq-simple-io#31 depends on this change. Is there a plan to release it sometime?

pmetzger commented 3 years ago

@liyishuai Would you like to do a release? I can add you to the maintainers of the repository.

liyishuai commented 3 years ago

Yes I'm happy to help maintaining this repo.

pmetzger commented 3 years ago

I've sent you a repository invite.

mjambon commented 3 years ago

thank you @pmetzger and @liyishuai!