search

ocaml-community / lambda-term

Terminal manipulation library for OCaml
Other
209 stars 43 forks source link

Enable mouse support in clock example #100

Closed avysk closed 3 years ago

avysk commented 3 years ago

Adds mouse support in clock example for #98

avysk commented 3 years ago

@jeremiedimino I didn't contribute to this for 7 years, so I'd appreciate a review of this and #101 even though the patches are small.

avysk commented 3 years ago

@jeremiedimino I didn't contribute to this for 7 years, so I'd appreciate a review of this and #101 even though the patches are small.

...or, maybe, judging by the commit history, @kandu can have a look?

avysk commented 3 years ago

It seems that this and #101 failed because of some Travis problem with doing os x build, not because of the changes. Maybe someone can re-run it? (The problem is very visible with #102 failing as well, even though the changes were only in the comment in a resource file example.)

pmetzger commented 3 years ago

I wouldn't worry much about the CI issues; we need to switch to a new CI soon anyway.

avysk commented 3 years ago

This (and #101) are very small and quite straightforward; any chance to get a review?

pmetzger commented 3 years ago

@kandu Can you review this? It's very small. If not, I will just merge it.