search

ocaml-community / lambda-term

Terminal manipulation library for OCaml
Other
209 stars 43 forks source link

Respect XDG for the inputrc config file #86

Closed copy closed 4 years ago

copy commented 4 years ago

Moves the .lambda-term-inputrc config file to ~/.config/.lambda-term-inputrc.

Prints a warning if ~/.lambda-term-inputrc exists, but still uses it.

kandu commented 4 years ago

Nice, it's a harmony of the recent utop enhancement(XDG folder). @pmetzger, what do you think?

kandu commented 4 years ago

merged, thank you, @copy

copy commented 4 years ago

Thanks!

frou commented 4 years ago

@copy isn't the convention that once such files are inside ~/.config/ then they shouldn't have a leading dot? They no longer need to be "hidden" since their containing directory is itself hidden.

copy commented 4 years ago

@frou Good point, you're absolutely right. @kandu What do you think about renaming the file to ~/.config/lambda-term-inputrc?

kandu commented 4 years ago

Neither of us spotted this flaw :expressionless:

What do you think about renaming the file to ~/.config/lambda-term-inputrc?

This is the quickest fix. We can apply it and cut a minor release. But shall we keep backward compatibility for the period of the major versions(3.x.x) before applying it? That is, cut a minor/patch version, with the dot-stripped file name inserted to the head of config file priority list.

When the time comes to bump the major version, we can revert this change and simply rename the file name.

copy commented 4 years ago

@kanda Good idea, will send a PR.