search

ocaml-community / ocaml-mariadb

OCaml bindings to MariaDB, supporting the nonblocking API
55 stars 18 forks source link

./configure is not mentioned in README #25

Closed ygrek closed 5 years ago

ygrek commented 5 years ago

it is required to call ./configure to build successfully, not ocaml setup.ml -configure as README advertises, which results in confusing : 

E: Failure("No variable mariadb_include_base defined when trying to expand \"let _ =\\n  let prefix = \\\"mariadb_stub\\\" in\\n  let generate_ml, generate_c = ref false, ref false in\\n  Arg.parse\\n    [(\\\"-ml\\\", Arg.Set generate_ml, \\\"Generate ML\\\");\\n     (\\\"-c\\\",  Arg.Set generate_c,  \\\"Generate C\\\")]\\n    (fun _ -> failwith \\\"unexpected anonymous argument\\\")\\n    \\\"stubgen [-ml|-c]\\\";\\n  match !generate_ml, !generate_c with\\n  | false, false | true, true ->\\n      failwith \\\"Exactly one of -ml and -c must be specified\\\"\\n  | true, false ->\\n      Cstubs.write_ml\\n        Format.std_formatter ~prefix (module Ffi_bindings.Bindings)\\n  | false, true ->\\n      print_endline \\\"#include <$(mariadb_include_base)/mysql.h>\\\";\\n      Cstubs.write_c\\n        Format.std_formatter ~prefix (module Ffi_bindings.Bindings)\\n\".")
andrenth commented 5 years ago

Fixed, thanks.