search

ocaml-community / ocaml-mariadb

OCaml bindings to MariaDB, supporting the nonblocking API
55 stars 18 forks source link

ctypes.foreign dependency is not needed #26

Closed ygrek closed 5 years ago

ygrek commented 5 years ago

it brings in libffi runtime dependency which is totally unnecessary

fix:

diff --git a/_oasis b/_oasis
index 3fd581c..9d913b9 100644
--- a/_oasis
+++ b/_oasis
@@ -54,7 +54,7 @@ Library "mariadb_bindings"
   Modules:          Ffi_bindings
   ByteOpt:          -warn-error +1..45
   NativeOpt:        -warn-error +1..45
-  BuildDepends:     ctypes.stubs, ctypes.foreign
+  BuildDepends:     ctypes.stubs

 Executable "ffi_stubgen"
   Install:          false

followed by oasis setup

ygrek commented 5 years ago

@andrenth do you have any reservations against this?

ygrek commented 5 years ago

ping

andrenth commented 5 years ago

Hi

Sorry for the delay. No reservations, I just haven't been working with OCaml lately, so my time is really limited for maintaining my libraries.

I'll apply this, rebuild my dev environment and see if I still remember how to make a release :)

andrenth commented 5 years ago

Just submitted version 1.1.2.

ygrek commented 5 years ago

Thanks!

ygrek commented 5 years ago

ctypes-foreign dependency is present in opam file and made it to opam-repository.