search

ocaml-community / sedlex

An OCaml lexer generator for Unicode
MIT License
239 stars 43 forks source link

prepare release (v2.0) #72

Closed smolkaj closed 5 years ago

smolkaj commented 5 years ago

This just updates the CHANGES doc in preparation of a new release. Since the switch from int codepoints to Uchar.t codepoints is a braking change -- for example, this will no longer compile -- I changed the version number to 2.0.

smolkaj commented 5 years ago

@pmetzger: Sorry I "dismissed" your review, I'm not super familiar with Github's latest reviewing process. Should be addressed.

pmetzger commented 5 years ago

@smolkaj: all looks good to me now. One last thing, I remember not being 100% happy with the "track lexing position" changes, though I wasn't a maintainer at the time. You might want to have a look and make sure you're personally comfortable with them. Otherwise, I feel fine with this.

smolkaj commented 5 years ago

Great! Re tracking the lexing position, I just skimmed over it very briefly. I don't have the time to take a closer look at the moment. Nonetheless, I suggest we move forward with a release in the meantime so at least there is a working version of sedlex on opam.

pmetzger commented 5 years ago

@smolkaj Thank you for doing the release! Do have a closer look at the tracking changes in the future if you can.

ELLIOTTCABLE commented 5 years ago

❤️ , omg.

I'm working on publishing v2.0 of bs-sedlex as I type!

Edit: It's out.