search

ocaml-community / sedlex

An OCaml lexer generator for Unicode
MIT License
235 stars 43 forks source link

Support for OCaml 4.08 #89

Closed mjustus closed 4 years ago

mjustus commented 4 years ago

In particular, this adds support for binding operators, which are new in version 4.08.

toots commented 4 years ago

Thanks for this! This looks good for me unless anyone objects? The failed CI seems to be a glitch, just restarted the one build that failed.

pmetzger commented 4 years ago

I haven't looked, but does this break earlier versions of ocaml?

toots commented 4 years ago

I don't think so, at least based on ppx_tools_versioned's description on opam:

% opam info ppx_tools_versioned

<><> ppx_tools_versioned: information on all versions <><><><><><><><><><><>  🐫
name                   ppx_tools_versioned
all-installed-versions 5.2.3 [4.08.0]
all-versions           5.0alpha  5.0beta  5.0beta1  5.0.1  5.1  5.2  5.2.1  5.2.2  5.2.3

<><> Version-specific details <><><><><><><><><><><><><><><><><><><><><><><>  🐫
version       5.2.3
repository    default
url.src:      "https://github.com/ocaml-ppx/ppx_tools_versioned/archive/5.2.3.tar.gz"
url.checksum: "md5=b1455e5a4a1bcd9ddbfcf712ccbd4262"
              "sha512=af20aa0031b9c638537bcdb52c75de95f316ae8fd455a38672a60da5c7c6895cca9dbecd5d56a88c3c40979c6a673a047d986b5b41e1e84b528b7df5d905b9b1"
homepage:     "https://github.com/ocaml-ppx/ppx_tools_versioned"
bug-reports:  "https://github.com/ocaml-ppx/ppx_tools_versioned/issues"
dev-repo:     "git://github.com/ocaml-ppx/ppx_tools_versioned.git"
authors:      "Frédéric Bour <frederic.bour@lakaban.net>"
              "Alain Frisch <alain.frisch@lexifi.com>"
maintainer:   "frederic.bour@lakaban.net"
license:      "MIT"
tags:         "syntax"
depends:      "ocaml" {>= "4.02.0"}
              "dune" {>= "1.0"}
              "ocaml-migrate-parsetree" {>= "1.4.0"}
synopsis      A variant of ppx_tools based on ocaml-migrate-parsetree
mjustus commented 4 years ago

Thanks for the quick response!

My understanding is that the purpose of ppx_tools_versioned is to provide backward compatibility. The CI results do seem to suggest that this is the case: dune runtest is successful even for OCaml 4.02.

toots commented 4 years ago

Yes, that is my understanding as well, ppx_tools_versioned provides transitive conversions from one version of the parse tree to the next. This would change the upper bound of supported versions.

Let's leave this open for another 24h and if nobody objects, I'll merge it.

vbgl commented 4 years ago

Is a release of version 2.2 (with support of OCaml 4.08) to be expected? Thanks.

toots commented 4 years ago

I can do one if no one objects.

dhcmrlchtdj commented 4 years ago

@toots will anyone publish the new version to OPAM? thanks

toots commented 4 years ago

Just did! Sorry this slipped through..