search

ocaml-community / utop

Universal toplevel for OCaml
Other
844 stars 112 forks source link

Fix unavailable expunge on Windows #447

Closed jonahbeckford closed 1 year ago

jonahbeckford commented 1 year ago

Without this commit, you get:

File "src/top/dune", line 33, characters 0-131:
33 | (rule
34 |  (targets utop-expunged.bc)
35 |  (action
36 |   (run %{ocaml_where}/expunge %{dep:utop.bc} %{targets}
37 |     %{read-lines:modules.txt})))
Error: File unavailable:
Z:/source/dkml/build/pkg/bump/.ci/o/PR/lib/ocaml/expunge
emillon commented 1 year ago

Ugh, of course 🤦🏻. Thanks. I should put a windows CI for this. I'll mark 2.13.0 as unavailable on windows. What's the right available: field for that? available: os != "win32"?

jonahbeckford commented 1 year ago

What's the right available: field for that? available: os != "win32"?

I think so.