ocaml-dune / binary-distribution

A web page for dune binary distribution
https://preview.dune.build/
ISC License
2 stars 5 forks source link

New landing page #37

Closed leostera closed 2 weeks ago

leostera commented 3 weeks ago

Not much to see here yet, just started drafting this page.

Moved us to MLX so its easier to see the final output of the page, and started using the dev preview to build this website. Works great!

The workflow is pretty annoying, since I have to run a while true; do dune exec sandworm -- ...; done and a separate server, and then manually reload the browser on every change.

This would be super smooth with something like astro.build but I want to honor the code we've written in OCaml so far – HOWEVER, there's a few things that'd be a lot better if we reused from JS world, like live-reloaders for styles.

I'm also using tailwind css.

This is based off the designs from Claire, with some content/structure adjustments based off Go's and Bun's websites.

Ref: https://www.figma.com/design/vSRUcQqOVTmRZqF1tD2Ov5/Dune-Download-Website?node-id=11-3&node-type=frame&t=LFqNbmPvTj45pZVv-0

image

leostera commented 3 weeks ago

Also yes I am quite jetlagged.

leostera commented 3 weeks ago

Some more changes here:

leostera commented 3 weeks ago

Updated screenshot:

Screenshot 2024-09-19 at 15 33 24
maiste commented 3 weeks ago

suggestion (ui,non-blocking): For the header, what do you think about adding more margin to the left and to the right, as in ocaml.org? It's definitely an aesthetic question, though. image

maiste commented 2 weeks ago

suggestion (blocking): I don't see any problem with using our own dune to build the website. However, I would suggest that we do it in another PR, related to the CI. It would make the diff much cleaner for the future, and the PR less heavy. Thus, my suggestion is to remove the dune.lock and reintroduce it later.

I have pushed two more commits to fix small stuffs as you suggested :+1: