ocaml-dune / binary-distribution

A web page for dune binary distribution
https://preview.dune.build/
ISC License
2 stars 5 forks source link

Release a tarball artifact #38

Closed gridbugs closed 1 week ago

gridbugs commented 2 weeks ago

This changes the github action to upload a tarball named like dune-2024-09-25-aarch64-apple-darwin.tar.gz. Extracting the tarball produces a directory named like dune-2024-09-25-aarch64-apple-darwin which contains the dune binary and the attestation file. This has several benefits over the current approach where users are required to download a dune exe directly:

Currently this just updates the github action - not the website - so this can't be merged as is. I'm opening this for review in its current state to get early feedback and to see if the deploy step of the github action works as expected (I couldn't figure out how to test this on my fork).

gridbugs commented 2 weeks ago

I started a manual run of the workflow here to test the deploy step: https://github.com/tarides/dune-binary-distribution/actions/runs/11035537631

gridbugs commented 1 week ago

As a conservative measure (until we fixed it), what do you think about publish bot the binary and the tar? We could remove the binary later?

Yep happy with this

leostera commented 1 week ago

@gridbugs is this mergeable?

gridbugs commented 1 week ago

I spoke with @maiste and they're going to integrate this into some other work they're doing.

maiste commented 1 week ago

The build failed. @gridbugs after discussing, the work in question will happen later. As we discussed, I will do some minors changes to fix it in the afternoon.

maiste commented 1 week ago

Closing in favor of #48.