Support monadic inputs.

ocaml-dune / csexp

Minimal support for Canonical S-expressions

MIT License

27 stars 7 forks source link

Support monadic inputs. #2

Closed mefyl closed 4 years ago

mefyl commented 4 years ago

The existing interface has been left untouched. The parser backend is now exposed and functorized over an arbitrary monad. The implementation is a bit verbose due to the lack of monadic binding syntax and the bareness of Result in 4.02.3.

Further considerations :

I could depend on base to get the Monad interface definition instead of introducing it for the bazillion time, but that would require 4.03.
I could provide Lwt driver in an optional library, but that may be overzealous.

ghost commented 4 years ago

I'd like to keep csexp minimal. In particular it is used by projects that don't currently depend on Base such as merlin, so let's not introduce a dependency on it.

For Lwt, the inter-op is now one simple functor application away, so yeah let's not be over-zealous :)

ghost commented 4 years ago

@mefyl are you happy to do the release in opam?

mefyl commented 4 years ago

Sure thing, but never did before. Is there a walkthrough somewhere ?

ghost commented 4 years ago

It should be documented in the --help of dune-release. But basically, you need to:

edit the changelog, set the next version number (1.2.0) and commit
install dune-release via opam
run dune-release tag to add a git tag (it will fetch the version number from the changelog)
run dune-release to do everything else, in particular create the opam-repo PR. The first time you run it, it will ask you a few questions such as your github username, etc...