ocaml-flambda / flambda-backend

The Flambda backend project for OCaml
93 stars 67 forks source link

Graduate mixed blocks from beta #2664

Closed ncik-roberts closed 1 month ago

ncik-roberts commented 1 month ago

We've decided to graduate mixed blocks from beta.

This is a one-line change plus annoying reshuffling of tests.

The test changes are hard to review, so let me describe the changes:

Renamed:

Merged:

How to review:

For the renamed files, you could just run this script, replacing diff with your favorite diff tool.

PRE=d3606621ba7f888293784b00186c03921e0bfa91
POST=58a4fe55d70f27d562e9a77fd3b74b3847622a38
DIFF=diff
function git-show-test () { git show $1:ocaml/testsuite/tests/$2; }
function diff-tests () {
  stable=$1
  beta=$2
  read -p "Diff between original beta test and final stable test: $beta -> $stable. Enter to continue."
  $DIFF <(git-show-test $PRE $beta) <(git-show-test $POST $stable) | less -R
  read -p "Diff between original stable test and final stable test: $beta -> $stable. Enter to continue."
  $DIFF <(git-show-test $PRE $stable) <(git-show-test $POST $stable) | less -R
}
function go () {
  diff-tests typing-layouts/mixed_records.ml typing-layouts/mixed_records_beta.ml
  diff-tests typing-layouts/mixed_constructor_arguments.ml typing-layouts/mixed_constructor_arguments_beta.ml
  diff-tests typing-layouts-float32/basics.ml typing-layouts-float32/basics_beta.ml
  diff-tests typing-layouts-float64/basics.ml typing-layouts-float64/basics_beta.ml
}
go