This PR continues the work in #2468 , and moves modalities on value descriptions to the new field pval_modalities.
In addition:
Adds parsing for modalities on primitives. I think primitives will have modes and modalities (and the user will be responsible for their correctness). But even if they don't, a type error is more friendly than a parsing error.
I choose not to add a modalities field to Ast_mapper. We can add it if needed in the future.
This PR continues the work in #2468 , and moves modalities on value descriptions to the new field
pval_modalities
.In addition:
modalities
field toAst_mapper
. We can add it if needed in the future.Request review from @freemagma