ocaml-gospel / gospel

A tool-agnostic formal specification language for OCaml.
https://ocaml-gospel.github.io/gospel
MIT License
128 stars 16 forks source link

Introduce a generic `pp_gen` pretty-printer for error messages #326

Closed shym closed 1 year ago

shym commented 1 year ago

Generalise the error pretty-printer so that its logic to fix the locations (due to preprocessing messing them up) can be reused directly by other tools using gospel as a library

shym commented 1 year ago

I rebased and changed the name of the new generic function, as pp_fix was too bound to the fact that it is fixing locations, while it also opens the way to displaying warnings.

n-osborne commented 1 year ago

This deserves an entry in the changelog, but I agree that pp_gen is a better name than pp_fix.

shym commented 1 year ago

I added a CHANGES entry and, as CI was happy, merged it.