Test condition tweaks - Githubissues

ocaml-multicore / domainslib

Parallel Programming over Domains

ISC License

173 stars 30 forks source link

Test condition tweaks #113

Closed jmid closed 1 year ago

jmid commented 1 year ago

This PR tweaks the conditions for some of tests

using a trick from https://github.com/ocaml/dune/issues/7845 to enable the backtrace test to also run on bytecode switches/platforms and
simplifying the "native only" test condition

The latter has the benefit of requiring no future tweaking when 5.1 is released with a restored native-code backend for s390x (and later again for ppc64).

jmid commented 1 year ago

The Windows failure is a known one, which will be fixed on 5.1: https://github.com/ocaml/ocaml/pull/12231

Sudha247 commented 1 year ago

That sounds good. We can bump the compiler version on Windows runs once 5.1 is released. Should we merge this one?

jmid commented 1 year ago

I fear a consistently red Windows CI workflow would have an unfortunate side-effect of being ignored. I've therefore just pushed 694f046 to hopefully turn this all green... :popcorn::crossed_fingers: (famous last words)

Sudha247 commented 1 year ago

It's all green!!