search

ocaml-multicore / domainslib

Parallel Programming over Domains
ISC License
171 stars 30 forks source link

Make domainslib build/run with OCaml 5.00 after PR #704 #53

Closed bikallem closed 3 years ago

bikallem commented 3 years ago

Updated CI to use opam repo @ https://github.com/kit-ty-kate/multicore-opam. So that we can use the ocaml 5.00 switch. (4.14.0+domains).

This will probably need to be reverted to original multicore-opam once the changes from kit-ty-kate is merged.

Note: After this PR is merged domainslib will be incompatible with 4.12.0+domains switch. We need to cherry pick PR#704 from 5.00 branch to 4.12.0+domains branch. The latter is no longer the case after https://github.com/ocaml-multicore/ocaml-multicore/pull/718

bikallem commented 3 years ago

ci with 5.00 works correctly. https://github.com/bikallem/domainslib/actions/runs/1372140682.

I am working on cherry-picking PR#704 to 4.12+domains/4.12+domains+effects. After which I will re-enable the ci for 4.12+domains branches again.

edit: converted the PR into a draft as I am still waiting for https://github.com/ocaml-multicore/ocaml-multicore/pull/718 to be merged into 4.12.0+domains branches

kayceesrk commented 3 years ago

Note: After this PR is merged domainslib will be incompatible with 4.12.0+domains switch. We need to cherry pick PR#704 from 5.00 branch to 4.12.0+domains branch.

IINM for the Tezos work, @Sudha247 is using 4.12.0+domains, isn't it?

Sudha247 commented 3 years ago

IINM for the Tezos work, @Sudha247 is using 4.12.0+domains, isn't it?

Yes, that's right. I think domainslib should work on 4.12.0+domains once https://github.com/ocaml-multicore/ocaml-multicore/pull/718 is pushed to 4.12.0+domains branch.

bikallem commented 3 years ago

hurrah! ci is finally green with the latest 4.12+domains+effects and 4.12+domains switches. ready for review.

/cc @Sudha247 @ctk21

Sudha247 commented 3 years ago

Merging.