search

ocaml-multicore / effects-examples

Examples to illustrate the use of algebraic effects in Multicore OCaml
ISC License
417 stars 35 forks source link

migrate effects-examples to use dune #22

Closed shubhamkumar13 closed 3 years ago

shubhamkumar13 commented 3 years ago

Migrate aio from ocamlbuild to dune #19

shubhamkumar13 commented 3 years ago

@kayceesrk I only found aio/.. using ocamlbuild so I ported it to dune also I wasn't sure if all the commands Makefiles using ocamlc/ocamlopt also need to be ported to dune. If so do let me know.

kayceesrk commented 3 years ago

Let's port all the builds to dune.

kayceesrk commented 3 years ago

The CI is failing for both the pipelines. Did you build it locally? and did it succeed locally?

shubhamkumar13 commented 3 years ago

The CI is failing for both the pipelines. Did you build it locally? and did it succeed locally?

Yes I ran it locally and it did succeed to build it locally

kayceesrk commented 3 years ago

Yes I ran it locally and it did succeed to build it locally

You should investigate CI failure. The MacOS build is known to succeed. See #21.