search

ocaml-multicore / effects-examples

Examples to illustrate the use of algebraic effects in Multicore OCaml
ISC License
417 stars 35 forks source link

Update to OCaml 5.1 in ci.yml #35

Closed kayceesrk closed 8 months ago

kayceesrk commented 9 months ago

I'm wondering why the CI keeps failing at multicont dependency. Would you know @dhil? CC @Sudha247.

Sudha247 commented 9 months ago

My guess is that something is probably off with GitHub actions caches. Is it possible to reset it somehow? We used to fetch the later compiler commit, as a hack.

As as aside, since the jobs run on Ubuntu and macOS, can we enable ocaml-ci and retire this action?

dhil commented 9 months ago

No idea. I just updated the multicont repo to use OCaml 5.1.0. It was seemingly successful: https://github.com/dhil/ocaml-multicont/commit/35871d9c715a026ac2ce3c1ca4c6a78338202a88.

Sudha247 commented 9 months ago

I went ahead and activated ocaml-ci. There are similar errors on some runs^^

dhil commented 9 months ago

I had another look at it. It seems like the header of tbz archive on the github release has been corrupted. I can try to recreate the tbz archive manually, but it will alter the hash. Will opam-repository let me change hash on the package retrospectively? Or should I do a new release altogether?

Sudha247 commented 9 months ago

@kit-ty-kate might know better (sorry for the ping!), but I think retroactive updates are accepted at opam-repository.

dhil commented 9 months ago

I have recompressed the archive and verified that I can extract with bzip2 now. I have opened a PR to change the hashes accordingly https://github.com/ocaml/opam-repository/pull/24586.

Sudha247 commented 9 months ago

The CI is fine now, thanks @dhil. Linting tests are failing; @kayceesrk do you mind if I just run ocamlformat globally and push to this branch? I'm asking because the diff is rather huge.

kayceesrk commented 9 months ago

Sure. Go ahead.