search

ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
548 stars 66 forks source link

Benchmarks have stopped working #565

Closed talex5 closed 1 year ago

talex5 commented 1 year ago

CI reports e.g.

dune exec -- ./bench/main.exe
Error: current-bench-data/duniverse/ocaml-iso639/dune-project: Permission
denied
make: *** [Makefile:7: bench] Error 1

(http://autumn.ocamllabs.io:8081/job/2023-06-23/103115-ocluster-build-a1126c)

/cc @Sudha247

Sudha247 commented 1 year ago

I noticed this just now too. Looks like a configuration issue. The same error shows up on lockfree as well - http://autumn.ocamllabs.io:8081/job/2023-06-22/142045-ocluster-build-f9e018. (ping @punchagan @ElectreAAS)

punchagan commented 1 year ago

Yes, I've noticed this too. Thanks for the ping. I'll look into this first thing on Monday. Sorry for the inconvenience.

talex5 commented 1 year ago

Thanks - will be useful to have benchmarks working again to see the effect of the changes in https://github.com/ocaml-multicore/eio/pull/567.

punchagan commented 1 year ago

The benchmarks are running again now. But looks like the PR #567 was merged before the benchmark run finished, and by default current-bench doesn't run benchmarks for closed/merged pull requests. The benchmark results for the merged commit are available here: https://autumn.ocamllabs.io/ocaml-multicore/eio/branch/main?worker=fermat&image=ocaml%2Fopam%3Adebian-ocaml-5.0

talex5 commented 1 year ago

Thanks @punchagan - that's very useful!