ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
548 stars 66 forks source link

Clarify configuration for lib_eio_linux and enable tests on other arches #592

Closed dra27 closed 1 year ago

dra27 commented 1 year ago

Following on #432. ocaml/ocaml#12405 proposes using linux everywhere for the "system" variable. The change doesn't semantically affect the build, but it seemed worth a clarifying comment not to rely on the old system values in future.

That said, the tests are presently not being run for it on non-amd64, so the second commit extends those as well.

talex5 commented 1 year ago

Would certainly be good to get this fixed! I guess we should wait for https://github.com/ocaml/ocaml/pull/12405 to be merged before merging this one.

talex5 commented 1 year ago

Thanks!