ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
548 stars 66 forks source link

Add Path.mkdirs #594

Closed patricoferris closed 11 months ago

patricoferris commented 1 year ago

As per one of the tasks in #510. I'm almost certainly doing something wrong... Unfortunately I don't have a windows machine so I blindly added the windows test.

patricoferris commented 1 year ago

Hmm I think the Linux error (or the macOS/Windows incorrect success) is caused by catching https://github.com/ocaml-multicore/eio/blob/355f8dabf28b229dc18285971ebbce62e2c4f3f1/lib_eio_posix/fs.ml#L158 hence the diff in the mdx test :/

talex5 commented 11 months ago

Closing in favour of the newer version in #625 - thanks!