search

ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
559 stars 72 forks source link

eio_posix: use directory FDs instead of realpath #694

Closed talex5 closed 9 months ago

talex5 commented 9 months ago

realpath was an old hack from the libuv days and isn't safe against races with symlinks being updated.

This should be faster too in some cases.

talex5 commented 9 months ago

The only noticeable change in the benchmarks is for the Path.stat rmtree time:

Before: Removed in 20.94 s After: Removed in 6.65 s

talex5 commented 9 months ago

I've merged this so we can get some more testing. Please file issues with any problems you notice!