search

ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
528 stars 67 forks source link

eio_linux: require Linux >= 5.15 #720

Closed talex5 closed 3 months ago

talex5 commented 3 months ago

This allows removing a work-around that required checking whether every flow was a tty (and which was doing this on every read).

On my machine, this doesn't seem to have much effect on the benchmarks, but it does clean up the strace output.

SGrondin commented 3 months ago

The linked PR mentions it being fixed in Linux 5.14 so I'm curious why >=5.15?

talex5 commented 3 months ago

Two reasons: 5.15 is what the CI machines are running (otherwise we might prefer 6.1 as the minimum), and I'm not sure 5.14 added any new uring operations, so detecting it would be harder.

avsm commented 3 months ago

I'm pretty uncomfortable with anything <6.6 for uring operations, so this one's fine by me :-)