ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
559 stars 72 forks source link

eio_posix: fix filesystem tests on OpenBSD #723

Closed jebrosen closed 7 months ago

jebrosen commented 7 months ago

Looks like someone beat me to it on OpenBSD compilation (#722), but I did see some failures in the test suite and found a solution. This fix seems reasonable to me, but I definitely might have missed something - these two functions have differed on this check since they were first introduced in #694.


In the 'resolve' function there is a check for items being symlinks which was missing ELOOP as an indicator. This patch adds ELOOP, to match the similar check in 'open_beneath_fallback'.

This fixes filesystem tests on OpenBSD.