search

ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
559 stars 72 forks source link

eio_windows: improve openat error handling #742

Closed talex5 closed 5 months ago

talex5 commented 5 months ago

@kentookura reported on #eio seeing this when doing Eio.Path.load:

Fatal error: exception Unix.Unix_error(Unix.ENOENT, "openat", "")

This patch adds the failing path argument to the Unix_error and wraps it as an Eio exception.

Also, the fs example is now run by the Windows CI (though I don't expect it to show this problem as it doesn't use open_dir).

kentookura commented 5 months ago

I should say that the error occurred without calling open_dir.