search

ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
559 stars 72 forks source link

Path.split does not work with backslash-encoded paths. #746

Closed kentookura closed 4 months ago

kentookura commented 5 months ago

If basename contains backslashes, it will return the string unmodified: https://github.com/ocaml-multicore/eio/blob/37840760b1b99fd9f59f0dbced315c72f08e639d/lib_eio/path.ml#L52-L65

talex5 commented 4 months ago

Backslashes are just normal filename characters for an Eio.Path:

https://github.com/ocaml-multicore/eio/blob/37840760b1b99fd9f59f0dbced315c72f08e639d/lib_eio/path.mli#L27-L28