Closed create2000 closed 1 month ago
So I am thinking, initially i used the Sys.os_type
to check if the current system is windows and if it is, it should skip the whole test. I am trying to know which would be a better approach between that and using this:
if not Unix.has_symlink then () else begin
I think has_symlink
is what we want. We still want to test on Windows when this is available :))
@patricoferris -- I have updated the code
Thanks @create2000 -- this looks better, but the git history now is a little confusing given you've made and undone changes. If you could reset back to the start and add just the changes for the symlink test that would be very much appreciated :))
@patricoferris I deleted this branch and have sent a new PR to ensure that my git history is not confusing. Hope this doesn't add more work. Thank you
This PR updates tests for improved compatibility across Windows and Unix-based systems. Specifically, it addresses the differences in symlink permissions and behaviors between these systems, and modifies the test_symlink function to handle these differences gracefully.
Key Changes
Testing: Tests were conducted on both Windows and Unix-like environments (WSL) to validate the compatibility improvements. Special attention was given to: