ocaml-multicore / eio

Effects-based direct-style IO for multicore OCaml
Other
559 stars 72 forks source link

Implementing the ``chmod`` support #772

Open webbunivAdmin opened 4 weeks ago

webbunivAdmin commented 4 weeks ago

Add chmod Support to Eio

This PR implements support for changing file permissions using the chmod operation in the Eio library.

764

Key Changes:

Tests:

webbunivAdmin commented 3 weeks ago

@patricoferris for checkout for the new tests have written

webbunivAdmin commented 3 weeks ago

@patricoferris for checkout for the new tests have written

patricoferris commented 2 weeks ago

Hey @webbunivAdmin,

A few notes from me here. Firstly, in terms of co-authoring, you only need to add this to your commits that are indeed co-authored by me. Everything after the initial commit is your own work and need not have co-authored on them.

Secondly, I do wonder what these pushes of update fs.md are for? Do you not have the code building and running locally to be able to run dune runtest to see if it is working before pushing. It is also possible to undo commits on your branch:

git reset --hard HEAD~n        # Reset head backwards n commits, dropping the commits
edit edit edit
git add foo                    # add new changes
git commit -m "Useful message" # commit them
git push -f                    # force push to your branch to undo the commits

Some of the failures right now are not due to the code (just flakey tests/CI). However, the latest code still has no test of the chmod feature.

webbunivAdmin commented 2 weeks ago

@patricoferris At last i made

patricoferris commented 6 days ago

Before reviewing @webbunivAdmin could you tidy up the Git history a little here. 35 of the 49 commits are called Update fs.md ^^" ! Mostly you could just squash the history with a soft reset and a force push to your branch.

webbunivAdmin commented 5 days ago

@patricoferris i thing am done

patricoferris commented 1 day ago

Hey @webbunivAdmin, sorry if I wasn't clear enough in my previous post. To make reviewing this easier could you tidy up the git history please. For example there is a pretty good stackoverflow post about how you can do that here: https://stackoverflow.com/questions/5189560/how-do-i-squash-my-last-n-commits-together

Does that make sense? If you don't want to squash the history do let me know and I'll take over the PR at some point to get it in a reviewable shape. Thanks :))