WIP: Skip network tests

create2000 commented 3 weeks ago

This is a work-in-progress for skipping tests when network is unavailable

create2000 commented 3 weeks ago

Hello @patricoferris -- I created a draft PR. In this PR i only added some `Eio_linux.run ~fallback:skip` to some functions. I want to know if that's okay, and if it is, how do i proceed with adding the skip feature to Mdx.

Also, after adding the Eio_linux.run ~fallback:skip, i still get this

...
@@ -133,6 +129,5 @@ Signalling an exited child does nothing:
   in
   ignore (Promise.await (Process.exit_status child) : Unix.process_status);
   Process.signal child Sys.sigkill;;
-FOO=bar
-- : unit = ()
+Exception: Failure "io_uring is not available (permission denied)".

How do i proceed?

PS: Is it okay to keep on contributing even after the Outreachy contribution stage period is over? I'd love to.

talex5 commented 3 weeks ago

This PR seems to change every file in the entire project (see https://github.com/ocaml-multicore/eio/pull/777/files). Possibly some kind of line-endings problem?

create2000 commented 3 weeks ago

Hello @talex5 @patricoferris --I don't know where the other corrections came in from but I have created a new PR and have added only the changed file. You can find it here

ocaml-multicore / eio

WIP: Skip network tests #777