ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml
https://ocaml-multicore.github.io/multicoretests/
BSD 2-Clause "Simplified" License
37 stars 16 forks source link

Disable cmd shrinking for int64 ref Thread test #389

Closed jmid closed 1 year ago

jmid commented 1 year ago

We are seeing long src/neg_tests/lin_tests_thread_ref.exe causing timeouts and long runs, primarily on Cygwin part 2 (examples below).

Since the experimental Lin Thread mode does not produce test failures as consistently as the Domain mode, this little PR disables cmd argument shrinking for the test, to limit how many shrinking candidates we have to traverse.

I've run focused tests which shows runs limited to at most 771.6s on Cygwin with the fix:

Examples of timeouts and long runs:

jmid commented 1 year ago

CI summary

That's 5 failures out of 55 (46+9) with only one being CI noise and no timeouts due to this PR. I'll go ahead and merge.