ocaml-multicore / multicoretests

PBT testsuite and libraries for testing multicore OCaml
https://ocaml-multicore.github.io/multicoretests/
BSD 2-Clause "Simplified" License
37 stars 16 forks source link

Chore: Lin DSL test renaming #408

Closed jmid closed 10 months ago

jmid commented 10 months ago

This PR is the sister PR to #396, eliminating historical occurrences of DSL and dsl in file and test names. Together, the effect of the two PRs is the following renaming:

lin_tests.ml      --> lin_internal_tests.ml      # for Lin_internal tests
lin_tests_dsl.ml  --> lin_tests.ml               # for Lin tests

The DSL name is historic and was eliminated before our initial opam package release. As Lin is the primary user-facing library for sequential consistency testing, I think this is preferable. It should be more intuitive to locate the right test with these names.

If done right, the PR should have no effect on test suite functionality... (I'm already seeing lots of weird red CI lights though! :grimacing: )

While at it, I also spotted a few tests that were missing from the overview in src/README.md.

jmid commented 10 months ago

I just restarted a bunch of jobs as roughly 1/2 of the GitHub actions workflows failed after seconds, due to some internal glitch I suppose. The restarted runs seem to progress fine though.

jmid commented 10 months ago

CI summary:

Out of 63 workflows (incl. 10 opam install ones) 5 failed, of which 4 were genuine and 1 was a borderline case

jmid commented 10 months ago

CI summary for merge to main:

Out of 38 workflows, 1 failed - with a genuine failure